Skip to content

add use_populator property to PVC #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2023
Merged

add use_populator property to PVC #1434

merged 3 commits into from
Sep 8, 2023

Conversation

@dalia-frank
Copy link
Contributor

@dalia-frank dalia-frank commented Sep 7, 2023

Short description:

Add a function to determine if DV was deployed using populators or not

More details:

The function check the relevant annotation on the DV

@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Sep 7, 2023

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To re-run tox comment /retest tox in the PR.
  • To re-run build-container command /retest build-container in the PR.
  • To re-run python-module-install command /retest python-module-install in the PR.
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported labels
  • hold
  • verified
  • wip
  • lgtm

myakove
myakove requested changes Sep 7, 2023
View reviewed changes
myakove
myakove requested changes Sep 7, 2023
View reviewed changes
rnetser
rnetser requested changes Sep 7, 2023
View reviewed changes
@dalia-frank dalia-frank changed the title add function is_deployed_by_populators to DV add use_populator property to PVC Sep 7, 2023
@dalia-frank
Copy link
Contributor Author

dalia-frank commented Sep 7, 2023

/verified

@myakove myakove merged commit c88fa16 into RedHatQE:main Sep 8, 2023
@dalia-frank
Copy link
Contributor Author

dalia-frank commented Sep 10, 2023

/cherry-pick v4.14

redhat-qe-bot pushed a commit that referenced this pull request Sep 10, 2023
@dalia-frank
add use_populator property to PVC (#1434)
b84d8f0 
* add function is_deployed_by_populators to DV

* change function to property

* fix per review
@redhat-qe-bot redhat-qe-bot mentioned this pull request Sep 10, 2023
Merged
@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Sep 10, 2023

Cherry-picked PR add use_populator property to PVC into v4.14

@myakove
Copy link
Collaborator

myakove commented Sep 10, 2023

/cherry-pick v4.15

@redhat-qe-bot
Copy link
Contributor

redhat-qe-bot commented Sep 10, 2023

Manual cherry-pick is needed
Cherry pick failed for c88fa16 to v4.15:
To cherry-pick run:

git remote update
git checkout v4.15
git pull origin v4.15
git checkout -b dv_populators-v4.15
git cherry-pick c88fa1691387eab378cf323ee77de982c88725fe
git push origin dv_populators-v4.15

redhat-qe-bot added a commit that referenced this pull request Sep 10, 2023
@redhat-qe-bot @dalia-frank
add use_populator property to PVC (#1434) (#1439)
e5ca84c 
* add function is_deployed_by_populators to DV

* change function to property

* fix per review

Co-authored-by: dalia-frank <65129017+dalia-frank@users.noreply.github.com>
dalia-frank added a commit to dalia-frank/openshift-python-wrapper that referenced this pull request Sep 10, 2023
@dalia-frank
add use_populator property to PVC (RedHatQE#1434)
dbfcfc1 
* add function is_deployed_by_populators to DV

* change function to property

* fix per review
myakove pushed a commit that referenced this pull request Aug 11, 2025
@dalia-frank
add use_populator property to PVC (#1434)
85fe55c 
* add function is_deployed_by_populators to DV

* change function to property

* fix per review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myakove myakove myakove approved these changes

@omrirh omrirh Awaiting requested review from omrirh

@oharan2 oharan2 Awaiting requested review from oharan2

@rnetser rnetser Awaiting requested review from rnetser

+1 more reviewer

@jpeimer jpeimer jpeimer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ApprovedBy-jpeimer ApprovedBy-myakove branch-main can-be-merged size/XS verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dalia-frank @redhat-qe-bot @myakove @rnetser @jpeimer